Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when bundling react-geosuggest with Browserify on node 0.10.x #95

Closed
holic opened this issue Feb 10, 2016 · 4 comments
Closed

Errors when bundling react-geosuggest with Browserify on node 0.10.x #95

holic opened this issue Feb 10, 2016 · 4 comments

Comments

@holic
Copy link

holic commented Feb 10, 2016

I have a project that pulls in react-geosuggest via npm. The project is bundled with Browserify + Babelify.

When I bundle this on node 0.10.x, I run into the following error:

23:05:12 Error: Cannot find module 'classnames' from '/src/node_modules/react-geosuggest/module'
23:05:12     at /src/node_modules/browserify/node_modules/resolve/lib/async.js:46:17
23:05:12     at process (/src/node_modules/browserify/node_modules/resolve/lib/async.js:173:43)
23:05:12     at ondir (/src/node_modules/browserify/node_modules/resolve/lib/async.js:188:17)
23:05:12     at load (/src/node_modules/browserify/node_modules/resolve/lib/async.js:69:43)
23:05:12     at onex (/src/node_modules/browserify/node_modules/resolve/lib/async.js:92:31)
23:05:12     at /src/node_modules/browserify/node_modules/resolve/lib/async.js:22:47
23:05:12     at Object.oncomplete (fs.js:107:15)

Bundling works on node v5.1.0, however.

As a workaround on node 0.10.x, I included classnames in our own package.json dependencies and bundling worked.

Happy to provide more details if it would help!

@holic holic changed the title Errors when bundling react-geosuggest with Browserify Errors when bundling react-geosuggest with Browserify on node 0.10.x Feb 10, 2016
@ro-ka
Copy link
Contributor

ro-ka commented Feb 11, 2016

I moved classnames as a real dependency. Should work in old node now, too. Released in 1.18.1

@ro-ka ro-ka closed this as completed Feb 11, 2016
@holic
Copy link
Author

holic commented Feb 11, 2016

Thanks for the quick fix!

On an unrelated note, I've never seen this badge before:
image

Any idea where that came from?

@ro-ka
Copy link
Contributor

ro-ka commented Feb 12, 2016

You’re welcome!

The badge is there because I’m a member of the @ubilabs org which is the owner of this package. Github seems to have introduced this some weeks ago.

@holic
Copy link
Author

holic commented Feb 12, 2016

Neat 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants