Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knip issues #9

Merged
merged 8 commits into from
Apr 8, 2024
Merged

Conversation

gitcoindev
Copy link
Contributor

Knip QA

gitcoindev and others added 3 commits April 8, 2024 13:32
…iguration

chore: add correct Knip workflow configuration
Remove unused dependencies, set public tag for public exports and add
unused files to ignore list.
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Lines Statements Branches Functions
Coverage: 81%
81.02% (158/195) 54.28% (19/35) 76.47% (13/17)

JUnit

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 8.137s ⏱️
Coverage Report (81%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files81.0254.2876.4781.02 
src/handlers78.754.8366.6678.7 
   generate-erc20-permit.ts79.0644.445079.0619–22, 26, 47, 53, 81–83
   generate-erc721-permit.ts88.46758088.4639–40, 69–70, 105–106
   generate-payout-permit.ts73.3333.3310073.3325–29
   register-wallet.ts68.88605068.8815–21, 43, 52, 61–64, 77–78
src/types100100100100 
   typeguards.ts100100100100 
src/utils87.55010087.5 
   keys.ts84.6133.3310084.6113–14, 18–19
   payoutConfigByNetworkId.ts100100100100 
tests100100100100 
   constants.ts100100100100 

@gitcoindev
Copy link
Contributor Author

Knip green, QA also done in my forked repository: gitcoindev#2

I noticed some spelling errors thrown by cspell, give me a minute and I will fix them in one go.

@gitcoindev
Copy link
Contributor Author

Knip green again, spelling issues fixed, pr ready for the review.

@gitcoindev gitcoindev mentioned this pull request Apr 8, 2024
@gitcoindev
Copy link
Contributor Author

Interestingly Knip detects i in yml wokflow files after yarn command e.g. yarn i as a standalone binary with name i. I had to change it to yarn install and the error was gone. I think we can leave the full install for clarity and remember to use it in all GitHub workflow files.

knip.ts Outdated Show resolved Hide resolved
@gentlementlegen gentlementlegen self-requested a review April 8, 2024 13:31
@gitcoindev gitcoindev merged commit 9901499 into ubiquity-os:development Apr 8, 2024
2 checks passed
@molecula451
Copy link

thanks for the PR, looks great

@molecula451
Copy link

let me review accordingly next time lol @gitcoindev

@gitcoindev
Copy link
Contributor Author

let me review accordingly next time lol @gitcoindev

Sure, I will!

Keyrxng pushed a commit to ubq-testing/permit-generation that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants