Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Penalty Improvement - Traceback #767

Closed
0x4007 opened this issue Sep 14, 2023 · 11 comments
Closed

Penalty Improvement - Traceback #767

0x4007 opened this issue Sep 14, 2023 · 11 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Sep 14, 2023

Dependencies

Overview

Let's name this table Penalties to represent instances where a contributor is penalized. This table keeps a record of the exact comment or incident due to which a penalty was applied.

Penalties

A ledger of penalties applied to contributors. This table provides a link to the exact comment or reason for the penalty, making the process transparent and traceable.

Schema

Field Type Description Example Value
id Integer Unique identifier for the penalty log entry. 1
created DateTime Timestamp when the penalty was logged. 2023-09-14T19:20:23.004Z
updated DateTime Timestamp when the penalty log was last updated. 2023-09-14T19:20:23.004Z
userId Integer GitHub id of the user penalized. 139262667
settlementId Integer Reference to the Settlements table. 512
orgId Integer GitHub id of the organization. 76412717
repoId Integer GitHub id of the repository where the issue is located. 534616569
issueId Integer GitHub id of the issue related to the penalty. 1868425596
commentURL String URL of the comment or incident leading to the penalty. #680 (comment)

Notes:

  • The commentURL field allows quick access to the exact comment or reason for the penalty.
  • I also made up the settlementIds as we currently do not have a table for those. However its spec is here Database Schema Design: October 2023 #787
  • Ensure foreign key constraints are set up properly to maintain data integrity.
  • We should rely on GitHub API's id properties instead of node_id Source.

Source

@wannacfuture
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 15, 2023

Too many assigned issues, you have reached your max of 2

@seprintour
Copy link
Contributor

/start

@ubiquibot
Copy link

ubiquibot bot commented Sep 19, 2023

Deadline Tue, 19 Sep 2023 22:43:15 UTC
Registered Wallet 0x3623338046b101ecEc741De9C3594CC2176f39E5
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @seprintour
    Copy link
    Contributor

    We'll probably need to change the schema to support a new table that has all the debt information. Basically a ledger of credits and debits which also associates the issue with each credit or debit. Example:

    @pavlovcik Maybe we can have another table called offset that is an array of repo that offsets a particular penalty

    created updated user credit org repo task offset
    2023-09-14T19:20:23.004Z 2023-09-14T19:20:23.004Z whilefoo -100 ubiquity ubiquibot 680 566, 447
    2023-09-14T19:20:32.554Z 2023-09-14T19:20:32.554Z whilefoo 150 ubiquity ubiquity-dollar 733 234, 444, 560

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 20, 2023

    @seprintour

    • Storing multidimensional data in a SQL database cell should be avoided
    • Also I updated the spec.

    @wannacfuture
    Copy link
    Contributor

    I think penalty_amount field should be added. @pavlovcik

    @seprintour
    Copy link
    Contributor

    /stop

    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 21, 2023

    You have been unassigned from the bounty @seprintour

    @0x4007
    Copy link
    Member Author

    0x4007 commented Sep 23, 2023

    @0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Sep 23, 2023

    ! Error: Permit generation disabled because this is marked as unplanned.

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants