Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Report the filter list containing the filter of a blocked request #43

Closed
gorhill opened this issue Jul 3, 2014 · 4 comments
Closed

Comments

@gorhill
Copy link
Contributor

gorhill commented Jul 3, 2014

I saw it as a separate issue, it was originally reported in #12 by @zerkms:

Just as a minor addition: it also might be helpful to show not only the exact filter applied, but also a subscription name that it came from.

@gorhill
Copy link
Contributor Author

gorhill commented Jul 4, 2014

Ideally, the exact filter list and line in that list would be great.

@gorhill
Copy link
Contributor Author

gorhill commented Jul 5, 2014

Not a straightforward feature. If uBlock were to keep track of where each filter originate exactly, it would gain a good chunk of memory and CPU footprint. Not going to happen. However, another solution is to reverse lookup, which in the current case is completely acceptable, since it's only a UI thing, and only for users which have an interest in that kind of information.

@gorhill
Copy link
Contributor Author

gorhill commented Feb 24, 2015

With the compiled filer lists in 0.8.8.5, this feature become closer to feasibility.

A compiled filter list could have an extra field which would be the offset at which the original filter is to be found in the original raw filter list.

It should be possible to infer a compiled filter entry from any live filter. So it would be a matter of finding the inferred compiled filter entry in any of the compiled filter lists which have been used to load the current filters. Since we are dealing with normalized entry, a plain string search can be used, fast.

But still, this will have to be on-demand only, as pointed out somewhere above. But more technically feasible now.

@chrisaljoudi
Copy link
Contributor

#1232

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants