feat: Enable Nvidia driver builds for v535 #122
Conversation
.github/workflows/build.yml
Outdated
| driver_version: [470, 520, 525, 530, 535] | ||
| exclude: | ||
| - driver_version: 525 | ||
| major_version: 37 | ||
| - driver_version: 525 | ||
| - driver_version: 470 | ||
| major_version: 38 | ||
| - driver_version: 520 | ||
| major_version: 37 | ||
| - driver_version: 520 | ||
| major_version: 38 | ||
| - driver_version: 470 | ||
| - driver_version: 525 | ||
| major_version: 37 | ||
| - driver_version: 525 | ||
| major_version: 38 |
There was a problem hiding this comment.
My OCD needed to fix the ordering of these... Both lists are now from oldest to newest :)
…ed Fedora version
p5
changed the title
| @@ -20,18 +20,12 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| major_version: [37, 38] | |||
| driver_version: [520, 525, 530, 470] | |||
| driver_version: [470, 530, 535] | |||
There was a problem hiding this comment.
Removes the v520 and v525 drivers since they are being excluded for both Fedora versions
|
I don't want this merging until v535 has been released to the regular repos and we've removed the sed commands which enable testing repos |
p5
changed the title
p5
changed the title
|
AFAICT, v535 has been released to the proper repos, so I have updated this PR and made it ready to merge. Only issue is Fedora 37 builds are failing, but I don't think that's due to any of my changes |
This is due to the lack of the 530 driver in the F37 repo. F37 RPMfusion has a 520 base and the update keeps only the latest driver so that means that Nvidia driver versions available for F37 are 340, 390, 520, 535 On the other hand F38 can be build with the 530 driver cause that the base driver version. so version that are available for F38 are 340, 390, 530, 535 That situation is normal and will happen each Nvidia driver update. the same issue will occurs if you try to keep 535 version on F38 when a newer version will be released. In short terms you need to drop 530 for fedora 37 it won't build any more so that's pointless. See pkgs.org to look for the avalible packages by yourself : https://pkgs.org/download/akmod-nvidia Also you can check on the F36 repo that has literally the same behavior |
| - driver_version: 520 | ||
| major_version: 37 | ||
| - driver_version: 520 | ||
| major_version: 38 | ||
| - driver_version: 470 |
There was a problem hiding this comment.
Exclude builds of 37 with driver version 530 here
- driver_version: 530
major_version: 37
There was a problem hiding this comment.
If you still wants some legacy in your version you can keep the 520 driver on fedora 37 cause it's the base driver so it will always be possible to build it.
However don't enable it on F38 cause the driver doesn't exists.
There was a problem hiding this comment.
Changes made in 182798f
I don't think we need to worry about enabling an older driver version in this PR - this was mainly just getting the new ones to build. I was hoping this would be a non-breaking update, but it turns out it broke on it's own.
There was a problem hiding this comment.
Sure that's fine to keep the latest only.
I was just saying this so you know what's possible to do or not in the current situation it might help understanding for the future so that kind of issue won't happen any more.
This PR makes the required changes to build the v535 NVIDIA drivers.
This can be merged when the packages have been released. You can see which repos each package is in here
https://rpmfind.net/linux/rpm2html/search.php?query=akmod-nvidia