Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Files and Folders are shown on git status #11

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Files and Folders are shown on git status #11

merged 1 commit into from
Feb 17, 2018

Conversation

ismaelbonato
Copy link
Collaborator

Remove Files and Folders from git status when I Run unity 8 on my desktop without installing and using Kdevelop4

Remove Files and Folders from git status when I Run unity 8 on my desktop without installing and using Kdevelop4
@ismaelbonato ismaelbonato changed the title Files and Folders are showed on git status Files and Folders are shown on git status Feb 16, 2018
@mardy mardy self-requested a review February 16, 2018 21:09
Copy link
Member

@mardy mardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@NeoTheThird
Copy link
Member

(not that i don't trust your judgment @mardy :D, i'd just like @mariogrip's two cents on if this is targeting the correct branch and how we want to go about keeping the branches in sync)

@ismaelbonato Awesome, thank you!

@mariogrip mariogrip merged commit 55fc104 into ubports:xenial_-_mir26 Feb 17, 2018
@mardy
Copy link
Member

mardy commented Feb 17, 2018

@NeoTheThird Indeed, whenever I review any submissions I'm paying far more attention to the changes, than to the target branch. So you are right in not hurrying up to merge things :-)

@ismaelbonato
Copy link
Collaborator Author

Which branch would be better to do Pull request? This branch is the only I can work properly on my rig for now. But with this initials changes I think it can be applied on the main branch if you want.

@ismaelbonato ismaelbonato deleted the patch-1 branch February 21, 2018 10:16
@mariogrip
Copy link
Member

@ismaelbonato Using xenial_-_mir26 or bionic is fine, we will try to keep these two in sync

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants