Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YaruPageIndicatorTheme #631

Closed
jpnurmi opened this issue Feb 24, 2023 · 5 comments · Fixed by #632
Closed

YaruPageIndicatorTheme #631

jpnurmi opened this issue Feb 24, 2023 · 5 comments · Fixed by #632
Assignees

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Feb 24, 2023

We would like to customize YaruPageIndicator to look like this in the installer:

image

Perhaps we could expose some BoxDecoration properties such as shape, color, and border for the different states (current vs. past vs. future) via YaruPageIndicatorTheme(Data)?

@Jupi007
Copy link
Member

Jupi007 commented Feb 24, 2023

That's a really good idea!
Have you already got some work in progress, or can I take it?

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 24, 2023

Sure, feel free to. :) I didn't start anything yet besides browsing around Flutter to see what kind of decoration-related properties they usually have in the theming APIs. Shape and border etc. seem to be quite common. :)

@Jupi007 Jupi007 self-assigned this Feb 24, 2023
@Jupi007
Copy link
Member

Jupi007 commented Feb 24, 2023

@jpnurmi I'd like to introduce some breaking changes, related to the way of compute and expose dot spacing and size. But it's not something which justify a new minor version right away.
So what do you think of have a separate branch like 2.2-dev where we could work on some new breaking features.
And when we are satisfied of the result, this branch could be merged into main.

This would allow to us some work flexibilities.
Also, as much as the app base who use this library grow, as much we should take care of smooth migrations.

If we go in that way, I could introduce the page indicator theme in main right now, but in addition to that, I could go further in the dev branch.

Jupi007 added a commit to Jupi007/yaru_widgets.dart that referenced this issue Feb 24, 2023
@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 24, 2023

@Jupi007 sounds like a good idea! don't stress too much about some layout breaks. it's a brand-new widget so not widely used yet :)

@Jupi007
Copy link
Member

Jupi007 commented Feb 24, 2023

Cool, thanks :)

It is not that I'm really worried about it, but more that if we need to bump the minor version for each change like that, it will become a little bit a mess of version. And also, I like to make things clean 😉

Jupi007 added a commit that referenced this issue Feb 24, 2023
Jupi007 added a commit that referenced this issue Feb 28, 2023
* Introduce YaruPageIndicatorTheme (#632)

Fixes #631

* Update PR template (#640)

* Example: upgrade handy_window to ^0.3.0 (#637)

* Example: add macOS (#635)

---------

Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants