Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce YaruPageIndicatorTheme #632

Merged
merged 5 commits into from Feb 24, 2023
Merged

Introduce YaruPageIndicatorTheme #632

merged 5 commits into from Feb 24, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Feb 24, 2023

I used a "decoration builder" because it allows to do special things like this:

Peek.24-02-2023.22-27.mp4

Fixes #631

Pull request checklist

  • This PR does not introduce visual changes

@Jupi007 Jupi007 requested a review from jpnurmi February 24, 2023 21:45
@Jupi007 Jupi007 added the 2.1 label Feb 24, 2023
@Jupi007 Jupi007 added this to the 2.1 milestone Feb 24, 2023
@Jupi007 Jupi007 removed the 2.1 label Feb 24, 2023
jpnurmi
jpnurmi reviewed Feb 24, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool! we might need to somehow communicate the current index to make it possible compare the "distance" to the current one?

lib/src/widgets/yaru_page_indicator.dart Show resolved Hide resolved
lib/src/widgets/yaru_page_indicator.dart Outdated Show resolved Hide resolved
jpnurmi
jpnurmi approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builder was a nice idea! LGTM 👍

@Jupi007 Jupi007 merged commit c2fbea0 into ubuntu:main Feb 24, 2023
@Jupi007 Jupi007 deleted the Jupi007/issue631 branch February 24, 2023 22:24
@Jupi007
Copy link
Member Author

Jupi007 commented Feb 24, 2023

Thanks 😊

Jupi007 added a commit that referenced this pull request Feb 28, 2023
@Jupi007 @jpnurmi
2.2-dev sync (#645)
bc6130e 
* Introduce YaruPageIndicatorTheme (#632)

Fixes #631

* Update PR template (#640)

* Example: upgrade handy_window to ^0.3.0 (#637)

* Example: add macOS (#635)

---------

Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
@jpnurmi jpnurmi mentioned this pull request Mar 2, 2023
Closed
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.x
Development

Successfully merging this pull request may close these issues.

YaruPageIndicatorTheme
2 participants
@Jupi007 @jpnurmi