Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #640

Merged
merged 2 commits into from Feb 25, 2023
Merged

Update PR template #640

merged 2 commits into from Feb 25, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Feb 25, 2023

I'd propose a drastically simpler PR template that should be helpful enough to the occasional new contributors but at the same time doesn't get in the way of the more frequent contributors.

<!-- REMINDER: If this PR introduces any visual changes, please run:
´´´
flutter test --update-goldens
´´´
and commit the changes **or** if not covered by tests, attach screenshots below:

|       | Before | After |
|-------|--------|-------|
| Light |        |       |
| Dark  |        |       |

-->

@Jupi007
Copy link
Member

Jupi007 commented Feb 25, 2023

As I said in the other PR, I like this one, but if somebody who doesn't know well this repo want to contribute, it could be confusing for him.

So maybe do something a bit longer, but clearer:

<!--
REMINDER: if any design change, run `flutter test --update-goldens`,
**or** if not covered by golden tests attach screenshots below, please

|       | Before | After |
|-------|--------|-------|
| Light |        |       |
| Dark  |        |       |
-->

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, you did it even better 👍

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 25, 2023

I went 100x back and forth with the wording... Definitely one of the hardest PRs today 🤣

@jpnurmi jpnurmi merged commit 56d55a1 into ubuntu:main Feb 25, 2023
@jpnurmi jpnurmi deleted the pr-template branch February 25, 2023 15:40
Jupi007 added a commit that referenced this pull request Feb 28, 2023
* Introduce YaruPageIndicatorTheme (#632)

Fixes #631

* Update PR template (#640)

* Example: upgrade handy_window to ^0.3.0 (#637)

* Example: add macOS (#635)

---------

Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants