Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: set ARBORIST_URL using the kube-setup-ohdsi.sh #2400

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix: set ARBORIST_URL using the kube-setup-ohdsi.sh #2400

merged 4 commits into from
Nov 2, 2023

Conversation

pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Oct 31, 2023 •
edited by jira bot
Loading

Jira Ticket: VADC-775

Bug Fixes

Deployment changes

  • compared to previous PR, this one assumes the arborist service is located on the same host as OHDSI - WebAPI

vzpgb
vzpgb previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vzpgb vzpgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

vzpgb
vzpgb previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@vzpgb vzpgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

m0nhawk
m0nhawk previously approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieterlukasse pieterlukasse dismissed stale reviews from m0nhawk and vzpgb via bd1b40a November 1, 2023 17:56
m0nhawk
m0nhawk approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pieterlukasse pieterlukasse force-pushed the fix/set_arborist_url_using_kube_setup_script branch from f41538e to 4c2c11b Compare November 1, 2023 19:12
@pieterlukasse pieterlukasse force-pushed the fix/set_arborist_url_using_kube_setup_script branch from 4c2c11b to 14cd7fb Compare November 1, 2023 19:17
@AidanHilt AidanHilt merged commit c965999 into master Nov 2, 2023
6 of 7 checks passed
@AidanHilt AidanHilt deleted the fix/set_arborist_url_using_kube_setup_script branch November 2, 2023 16:22
This was referenced Nov 29, 2023
Open
Merged
Merged
This was referenced Dec 8, 2023
Merged
Merged
This was referenced Dec 11, 2023
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Merged
This was referenced Jan 16, 2024
Merged
Closed
This was referenced Feb 2, 2024
Closed
Merged
This was referenced Feb 16, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nhawk m0nhawk m0nhawk approved these changes

@vzpgb vzpgb vzpgb left review comments

Assignees
No one assigned
Labels
skip-gen3-helper-tests test-coremetadata-getCoremetadataTest test-portal-coremetadatapageTest test-portal-indexingPageTest test-sheepdogAndPeregrine-submitAndQueryNodesTest test-sheepdogAndPeregrine-submitFileTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pieterlukasse @m0nhawk @vzpgb @AidanHilt @PlanXCyborg