Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/index scoped tiered access #802

Merged
merged 12 commits into from
Feb 18, 2021
Merged

Conversation

ZakirG
Copy link
Contributor

@ZakirG ZakirG commented Feb 10, 2021

Jira Ticket: https://ctds-planx.atlassian.net/browse/HP-31

New Features

  • Adds support for index-scoped tiered access. New optional config property, tierAccessLevel, in each tab of the explorerConfig block in the portal config. Index-scoped tiered-access only available since Guppy server version 0.11.0. See README for more information.

Deployment Changes

  • New optional config property, tierAccessLevel, in each tab of the explorerConfig block in the portal config. Used to enable index-scoped tiered-access, which is only available starting with Guppy server version 0.11.0. See README for more information.

@mpingram mpingram self-requested a review February 12, 2021 20:31
Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think whatever you put into Dependency updates should goes into Deployment changes

// contain a tierAccessLevel.
let indexScopedTierAccessMode = true;
explorerConfig.forEach((item) => {
if (!item.guppyConfig || !item.guppyConfig.tierAccessLevel) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: probably should just freak out if there is no guppyConfig, that block is required for each explorer tab

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the localconf.js file does not throw any errors or intentionally abort builds. i'm gonna keep with that convention

@mfshao
Copy link
Collaborator

mfshao commented Feb 12, 2021

and also might be good to mention index-scoped access level only available since guppy version XXX

@ZakirG
Copy link
Contributor Author

ZakirG commented Feb 12, 2021

and also might be good to mention index-scoped access level only available since guppy version XXX

for sure, i'll add that once Marcelo has QA'd my Guppy PR and it's merged and versioned

Copy link
Collaborator

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally lgtm, let's merge after uc-cdis/guppy#104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants