Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal-icgc pcawg 2022.03 2021.06 internal-icgc.bionimbus.org 1647626564 #4337

Merged
merged 1 commit into from
Mar 18, 2022
Merged

internal-icgc pcawg 2022.03 2021.06 internal-icgc.bionimbus.org 1647626564 #4337

merged 1 commit into from
Mar 18, 2022

Conversation

PlanXCyborg
Copy link
Contributor

Applying version 2021.06 to internal-icgc.bionimbus.org

@PlanXCyborg
Copy link
Contributor Author

internal-icgc.bionimbus.org/manifest.json

Deployment changes

Breaking changes

  • arborist
    • In step with Fence changes to issued JWTs, in which scopes are moved into a dedicated scope claim (Fence 4.22.2/2020.08) and out of the aud claim (Fence 5.0.0/2021.07), this commit changes Arborist JWT validation logic so that it does the same validation it was doing on the aud field, but does it on the scope field instead. This Arborist version must therefore be paired with a Fence later than 4.22.2/2020.08. Conversely, Fence 5.0.0/2021.07 will require Arborist later than this commit. ((PXP-6617): remove scopes from jwt aud claim arborist#130)
  • guppy
    • User can only see/query the data for a project if they have the following access: method read (or * - all methods) to service guppy (or * - all services) on that project resource. (previously they can see/query all the data if you any types of access to them) (PXP-6412 Feat/auth mapping guppy#93)
  • portal
  • sheepdog
    • Note that this PR will cause Sheepdog behavior to change slightly during a data submission flow in which the acl and/or authz field are previously populated in the corresponding Indexd record and the Indexd uploader field is not null and the Sheepdog submitter does not match the Indexd uploader. While the existing behavior will cause data submission to fail and report an error message to the user, this PR’s changes will mean that data submission can still succeed in this case of populated acl/authz and uploader mismatch. I believe this change in behavior is not problematic in that it would be unexpected in any commons for uploader and (acl and/or authz) to both be populated. ((PXP-6580): fix data submission by only writing acl and authz iff both are empty sheepdog#330)

@trevars trevars self-requested a review March 18, 2022 19:45
@trevars trevars merged commit 9126e68 into master Mar 18, 2022
@trevars trevars deleted the chore/apply_202106_to_internal-icgc_bionimbus_org_1647626566 branch March 18, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevars trevars trevars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PlanXCyborg @trevars