PXP-8448 - Register users for download #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Aug 18, 2021
mfshao
reviewed
Aug 18, 2021
mfshao
reviewed
Aug 18, 2021
There was a problem hiding this comment.
Much better, but I found 1 problem when testing on qa-midrc
When I get redirected to the Login page, after login I was presented with the Fence registration page. But if I click Maybe Later instead of filling out the form, portal still redirects me back. And I can begin to download even if I didn't actually finishes the registration
Maybe this is a bug from your Fence branch? Maybe you should check from Portal whether a user has finished registrastion from Fence? Maybe you should just remove the Maybe Later button from Fence so they will have no chance not registering them? 🤔
mfshao
reviewed
Aug 19, 2021
rnerella92
force-pushed
the
registeredUsers
branch
from
f5df563
to
1b4a7db
Compare
mfshao
reviewed
Aug 24, 2021
added 13 commits
August 26, 2021 10:14
rnerella92
force-pushed
the
registeredUsers
branch
from
cfb044f
to
44ce714
Compare
This was referenced Sep 3, 2021
Merged
Closed
This was referenced Jan 10, 2022
This was referenced Mar 21, 2022
This was referenced Mar 29, 2022
Closed
Closed
jacquayj
pushed a commit
to bioteam/data-portal
that referenced
this pull request
Apr 6, 2022
* added new config variable to turn on/off registered users functionality for MIDRC * updated button logic for download * updated config variable name * removed unused proptypes * updated config variable name and included config i portal_config.md * updated enlist errors * updated logic to redirect only for download buttons * added updates based on comments * added updates based on comments * Updated location prop * updated the config variable name * updated markdown file * removed commented code and updated function blocks Co-authored-by: Ramu Nerella <ramunerella@Ramus-MacBook-Pro.local>
This was referenced Apr 30, 2022
This was referenced Jun 23, 2022
This was referenced Dec 19, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When the users are not logged in and try to download data they will be redirected to the login page. This change will come into effect if the 'loginForDownload' variable is set to 'true' in gitops.json.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes
loginForDownloadflag set to true in gitops