-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/usersync update role #843
Conversation
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 10514
💛 - Coveralls |
This pull request introduces 1 alert when merging 4c25019 into 50ff568 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f6bcb31 into ba0b1fc - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 76f4461 into 9826912 - view on LGTM.com new alerts:
|
needs re-review after dep update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Pauline Ribeyre <ribeyre@uchicago.edu>
…/fence into fix/usersync-update-role merge
Problem: previously the usersync job would fail to modify existing roles in Arborist -this is because the Arborist API didn't have a PUT /role/{roleID} endpoint
Solution: this PR solves this problem by having Fence hit the newly implemented PUT /role/{roleID} Arborist endpoint
Note: this is a non-destructive code change in that the new usersync logic is:
That is to say - ideally in a given environment Fence and Arborist would be updated to these latest versions simultaneously, BUT if for whatever reason that's not possible - it would not cause any errors to only update Fence with this new version without updating Arborist.
Similarly, it would not cause any errors to only update the Arborist deployment without updating Fence, because the only difference would be that now that Arborist deployment has a new API endpoint that simply doesn't get used anywhere.
Bug Fixes