Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google_sa): new endpoint should replicate exactly what SA signed … #921

Merged
merged 6 commits into from
May 27, 2021
Merged

fix(google_sa): new endpoint should replicate exactly what SA signed … #921

merged 6 commits into from
May 27, 2021

Conversation

Avantol13
Copy link
Contributor

…URLs are using, correct

New Features

Breaking Changes

Bug Fixes

  • /google/primary_google_service_account was returning the client/user SA, which is NOT what is used for signed urls. this PR corrects the behavior to create and return the user's single primary service account

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented May 25, 2021 •
edited

Pull Request Test Coverage Report for Build 11090

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 70.769%
Totals Coverage Status
Change from base Build 11084: 0.003%
Covered Lines: 6038
Relevant Lines: 8532
💛 - Coveralls

vpsx
vpsx reviewed May 26, 2021
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@Avantol13 Avantol13 merged commit b85118f into master May 27, 2021
@Avantol13 Avantol13 deleted the fix/google_primary branch May 27, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpsx vpsx vpsx approved these changes

Assignees
No one assigned
Labels
test-apis-dbgapTest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Avantol13 @coveralls @vpsx @Avantol13-machine-user