Feat/create presigned url passports #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate_presigned_url_passports
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
…eate_presigned_url_passports
Pull Request Test Coverage Report for Build 12041
💛 - Coveralls |
fence/blueprints/data/indexd.py
Outdated
| @@ -1434,21 +1460,28 @@ def delete(self, container, blob): # pylint: disable=R0201 | |||
| return ("Failed to delete data file.", status_code) | |||
|
|
|||
|
|
|||
| def _get_user_info(sub_type=str): | |||
| def _get_user_info(sub_type=str, user=None): | |||
| """ | |||
| Attempt to parse the request for token to authenticate the user. fallback to | |||
| populated information about an anonymous user. | |||
| By default, cast `sub` to str. Use `sub_type` to override this behavior. | |||
| """ | |||
| # TODO Update to support POSTed passport | |||
There was a problem hiding this comment.
We can take this TODO comment out, right?
|
|
Avantol13
approved these changes
Nov 29, 2021
| raise Unauthorized( | ||
| f"Either you weren't logged in or you don't have " | ||
| f"{action_to_permission[action]} permission " | ||
| f"on authz resource: {self.index_document['authz']}" | ||
| ) | ||
| authorized_user_id = ( | ||
| authorized_user_id if isinstance(authorized_user_id, str) else None |
There was a problem hiding this comment.
why is this necessary? I assume it's b/c the function below expects None and not something False-y? Is it even possible for the above function to return ""?
| google_proxy_group, | ||
| primary_google_service_account, | ||
| cloud_manager, | ||
| google_signed_url, | ||
| monkeypatch, | ||
| ): |
There was a problem hiding this comment.
In a new PR can we get some quick, small docstrings about what these tests are actually testing for in more detail? Don't worry about doing it in this PR since the tests are already passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
POST /ga4gh/drs/v1/objects/<guid>/access/<access method>endpoint with passportsPOST /ga4gh/drs/v1/objects/<guid>/access/<access method>endpoint with passportsImprovements
Dependency updates
Deployment changes