Skip to content

Commit

Permalink
minor cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
tianj7 committed Jul 12, 2022
1 parent 5b0908b commit 1f68219
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 35 deletions.
20 changes: 10 additions & 10 deletions .secrets.baseline
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "(docs\\/_build|poetry.lock)|^.secrets.baseline$",
"lines": null
},
"generated_at": "2022-07-12T20:07:40Z",
"generated_at": "2022-07-12T20:56:54Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -344,55 +344,55 @@
{
"hashed_secret": "6487fa7aea293dfde99cda9c6ccb9161219331c7",
"is_verified": false,
"line_number": 109,
"line_number": 110,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "96c9184fb19c9c1618ccf44d141f8029a739891c",
"is_verified": false,
"line_number": 423,
"line_number": 424,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "e1da93616713812cb50e0ac845b1e9e305d949f1",
"is_verified": false,
"line_number": 558,
"line_number": 559,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "47f42f4c34fddab383b817e689dc0fb75af81266",
"is_verified": false,
"line_number": 582,
"line_number": 583,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "300d95dd5d30ab6928ffda6c08c6a129a23e5b39",
"is_verified": false,
"line_number": 606,
"line_number": 607,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "f9e664db75c7f23a299b0b055c10e08d47073e93",
"is_verified": false,
"line_number": 674,
"line_number": 675,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "7c35c215b326b9463b669b657c1ff9873ff53d9a",
"is_verified": false,
"line_number": 888,
"line_number": 889,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "0d515eaf06062d52e8c80abb4d3b713a65396d30",
"is_verified": false,
"line_number": 892,
"line_number": 893,
"type": "Hex High Entropy String"
},
{
"hashed_secret": "b4cff7c2af45cdfe66195ec574a7b8832f8621ea",
"is_verified": false,
"line_number": 897,
"line_number": 898,
"type": "Hex High Entropy String"
}
],
Expand Down
50 changes: 25 additions & 25 deletions gen3/tools/indexing/index_manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -375,31 +375,31 @@ def index_object_manifest(
output_filename(str): output file name for manifest
submit_additional_metadata_columns(bool): whether to submit additional metadata to the metadata service
force_metadata_columns_even_if_empty(bool): force the creation of a metadata column
entry for a GUID even if the value is empty. Enabling
this will force the creation of metadata entries for every column.
See below for an illustrative example
Example manifest_file:
guid, ..., columnA, columnB, ColumnC
1, ..., dataA, ,
2, ..., , dataB,
Resulting metadata if force_metadata_columns_even_if_empty=True :
"1": {
"columnA": "dataA",
"columnB": "",
"ColumnC": "",
},
"2": {
"columnA": "",
"columnB": "dataB",
"ColumnC": "",
},
Resulting metadata if force_metadata_columns_even_if_empty=False :
"1": {
"columnA": "dataA",
},
"2": {
"columnB": "dataB",
},
entry for a GUID even if the value is empty. Enabling
this will force the creation of metadata entries for every column.
See below for an illustrative example
Example manifest_file:
guid, ..., columnA, columnB, ColumnC
1, ..., dataA, ,
2, ..., , dataB,
Resulting metadata if force_metadata_columns_even_if_empty=True :
"1": {
"columnA": "dataA",
"columnB": "",
"ColumnC": "",
},
"2": {
"columnA": "",
"columnB": "dataB",
"ColumnC": "",
},
Resulting metadata if force_metadata_columns_even_if_empty=False :
"1": {
"columnA": "dataA",
},
"2": {
"columnB": "dataB",
},
Returns:
files(list(dict)): list of file info
Expand Down
1 change: 1 addition & 0 deletions tests/test_manifests.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def test_verify_manifest(mock_index):
"""
Test that verify manifest function correctly writes out log file
with expected error information.
NOTE: records in indexd are mocked
"""
mock_index.return_value.async_get_record.side_effect = _async_mock_get_guid
Expand Down

0 comments on commit 1f68219

Please sign in to comment.