MIDRC-536 MIDRC-653 Add expiration bucket lifecycle rule #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please find the detailed integration test report here Please find the ci env pod logs here |
Please find the detailed integration test report here Please find the ci env pod logs here |
nss10
previously approved these changes
Jun 17, 2024
paulineribeyre
force-pushed
the
feat/nf-expire-files
branch
from
b0ef0e0
to
b2a38c1
Compare
Please find the detailed integration test report here Please find the ci env pod logs here |
nss10
reviewed
Jul 18, 2024
| @@ -233,14 +233,14 @@ var isUserAuthorizedForPayModels = func(userName string, allowedPayModels []stri | |||
| var isUserAuthorizedForResourcePaths = func(userName string, accessToken string, resourcePaths []string) (bool, error) { | |||
| Config.Logger.Printf("DEBUG: Checking user '%s' access to resource paths %v (service 'jupyterhub', method 'launch')", userName, resourcePaths) | |||
|
|
|||
| body := "{ \"requests\": [" | |||
| body := fmt.Sprintf("{\"user\": {\"token\": \"%s\"}, \"requests\": [", accessToken) | |||
There was a problem hiding this comment.
Wondering why do we need to change this? Is sending the access token as a Bearer token not working anymore?
There was a problem hiding this comment.
it never worked, this arborist endpoint expects the token in the body
nss10
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-536, https://ctds-planx.atlassian.net/browse/MIDRC-653
New Features
nextflow-global.s3-objects-expiration-dayssetting to configure when to delete objects created in S3 by NextflowBreaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes