This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Feat/workflow db #53
Merged
Feat/workflow db #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
2 times, most recently
from
0581cd0
to
c9d076a
Compare
kmhernan
reviewed
Aug 16, 2021
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
5 times, most recently
from
dc75663
to
9aac2a3
Compare
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
5 times, most recently
from
e673da8
to
47d67ee
Compare
| "os" | ||
|
|
||
| log "github.com/sirupsen/logrus" |
database/psqldb.go
Outdated
| db.DBName = credential.DatabaseName | ||
| } | ||
|
|
||
| func (db *PSQLDataBase) Initalize() { |
There was a problem hiding this comment.
A common Go pattern is to use Must<DoSomething> for method/function names to imply that something must occur and if an error happens the app will crash. We may want to do that here. Right now, getCredentials does nothing if it finds errors. I think it should probably return an err and we should log.Fatal if an err exists
database/psqldb.go
Outdated
|
|
||
| func (db *PSQLDataBase) Connect() (string, error) { | ||
| psqlInfo := fmt.Sprintf("host=%s user=%s "+ | ||
| "password=%s dbname=%s sslmode=disable", //pragma: allowlist secret |
There was a problem hiding this comment.
Are we not able to use ssl today?
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
18 times, most recently
from
2966787
to
1d15505
Compare
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
2 times, most recently
from
5977b38
to
3d5311c
Compare
database/psqldb_dao.go
Outdated
| return 0, fmt.Errorf("could not create user") | ||
| } | ||
|
|
||
| log.Infof("Sucessfully created user with name %s and email %s", name, email) |
There was a problem hiding this comment.
Suggested change
| log.Infof("Sucessfully created user with name %s and email %s", name, email) | |
| log.Infof("Sucessfully created user with id %d", userId) |
We should avoid logging potentially sensitive user information. Either of these fields could be considered PII
database/psqldb_dao.go
Outdated
| return fmt.Errorf("update user failed") | ||
| } | ||
|
|
||
| log.Infof("User %s updated successfully", user.Name) |
There was a problem hiding this comment.
Suggested change
| log.Infof("User %s updated successfully", user.Name) | |
| log.Infof("User %d updated successfully", user.ID) |
williamhaley
approved these changes
Aug 25, 2021
UchicagoZchen138
force-pushed
the
feat/workflow-db
branch
from
3d5311c
to
cd386b4
Compare
williamhaley
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is the work for PXP-8095 which will set up a db interface layer to interact with a psql db that mariner will talk to. unit tests have been added and no breaking changes introduced.