This repository has been archived by the owner on Jul 14, 2022. It is now read-only.

Feat/integrate aws gateway and indexd commonsfiles #65

Merged

UchicagoZchen138 merged 3 commits into master from feat/integrate-aws-gateway-and-indexd-commonsfiles

Oct 29, 2021

Contributor

UchicagoZchen138 commented Oct 25, 2021

Make requests to Indexd to get file names for commons files
Redefined ToolS3Inputs struct
Rework InitWorkDir to handle commons files
Rework s3sidecar to download commons and user files and handle initwkdir
Mount gateway to /commons-files and mount to s3sidecar container

UchicagoZchen138 and others added 2 commits

October 25, 2021 15:19


          feat(aws-gateway): add aws gateway as mount

d411622


          feat(indexd): use indexd to get commons files

8a0c011

UchicagoZchen138 commented

View reviewed changes

mariner/engine.go Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

mariner/input.go Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

mariner/input.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

mariner/utility.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

mariner/utility.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

mariner/utility.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

sidecar/sidecar.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

sidecar/sidecar.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

sidecar/sidecar.go Outdated Show resolved Hide resolved

UchicagoZchen138 commented

View reviewed changes

sidecar/sidecar.go Outdated Show resolved Hide resolved

UchicagoZchen138 force-pushed the feat/integrate-aws-gateway-and-indexd-commonsfiles branch 2 times, most recently from e4917cc to 698582e Compare

October 27, 2021 22:23

UchicagoZchen138 requested a review from m0nhawk

October 28, 2021 14:52

kmhernan reviewed

View reviewed changes

mariner/utility.go Outdated

+              type IndexFileInfo struct {
+              	Filename string   `json:"file_name"`
+              	Filesize uint64   `json:"size"`
+              	DID      string   `json"did"`

Contributor

kmhernan Oct 28, 2021

oh this is missing an : -> json:"did" but DID isn't even used currently


          refactoring

b1672df

UchicagoZchen138 force-pushed the feat/integrate-aws-gateway-and-indexd-commonsfiles branch from 698582e to b1672df Compare

October 28, 2021 16:41

kmhernan self-requested a review

October 28, 2021 17:39

kmhernan approved these changes

View reviewed changes

Contributor

kmhernan left a comment

I think this is in the right place to merge so we can move on to the next task of getting the file metadata into the CWL logic side.

UchicagoZchen138 merged commit b0e31d2 into master

UchicagoZchen138 deleted the feat/integrate-aws-gateway-and-indexd-commonsfiles branch

November 11, 2021 20:49

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.