This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Feat - get metadata for commons files #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariner/tool.go
Outdated
| @@ -47,6 +47,14 @@ func pathHelper(path string, tool *Tool) (err error) { | |||
| InitWorkDir: true, | |||
| }) | |||
| tool.initWorkDirFiles = append(tool.initWorkDirFiles, path) | |||
| } else if strings.HasPrefix(path, "/"+commonsDataVolumeName) { | |||
There was a problem hiding this comment.
do we need a "/" here?
UchicagoZchen138
force-pushed
the
feat/PXP-8902-file-metadata
branch
2 times, most recently
from
b5827bf
to
48fa3ee
Compare
UchicagoZchen138
force-pushed
the
feat/PXP-8902-file-metadata
branch
from
48fa3ee
to
681e5c1
Compare
UchicagoZchen138
approved these changes
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally opened to use the indexd method to get metadata as described in PXP-8902 but we were able to get around this by using a different kind of path.
/commons-data/paths in init workdir