Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & clarify hierarchical flows #1368

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Fix & clarify hierarchical flows #1368

merged 3 commits into from
Feb 24, 2023

Conversation

harrisonliew
Copy link
Contributor

@harrisonliew harrisonliew commented Feb 24, 2023

This fixes a small bug with the hierarchical VLSI flow for power-par and adds clarifying documentation nothing that hierarchical flows must be cognizant about overriding VLSI_TOP.

@bdngo @moresa75

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

docs/VLSI/Basic-Flow.rst Outdated Show resolved Hide resolved
@harrisonliew harrisonliew merged commit 58590f2 into main Feb 24, 2023
@harrisonliew harrisonliew deleted the power-mk-fix branch February 24, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants