Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-syn/par sim #1369

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Fix post-syn/par sim #1369

merged 5 commits into from
Mar 10, 2023

Conversation

harrisonliew
Copy link
Contributor

In #1324 I consolidated the input files for simulation, but broke post-syn/par simulation as a result.
This PR makes sure that no TOP Verilog files make it to post-syn/par sims.
Being tested by @bdngo
@moresa75

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@harrisonliew harrisonliew marked this pull request as ready for review February 28, 2023 21:11
@bdngo
Copy link

bdngo commented Feb 28, 2023

I am currently testing this with ChipTop post-synthesis flows, currently depending on a RocketTile and a backing scratchpad.

@harrisonliew harrisonliew merged commit a8c9c82 into main Mar 10, 2023
@harrisonliew harrisonliew deleted the sim-syn-par-fix branch March 10, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants