Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to peripheral fragments #1518

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Revert changes to peripheral fragments #1518

merged 2 commits into from
Jun 15, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Jun 15, 2023

Sorry about this @T-K-233 , there's a very minor incompatibility issue in here with some existing configs. We'd normally just fix this the correct way, but there's an exceptional time constraint right now.

I'll open a PR re-adding this in a moment.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@T-K-233
Copy link
Member

T-K-233 commented Jun 15, 2023

Sounds good.

Sorry for the hassle I created.

@jerryz123
Copy link
Contributor Author

The problem is other less cleanly written code breaking with your changes, your changes are all good 😄

@jerryz123 jerryz123 merged commit 4b95a32 into main Jun 15, 2023
26 checks passed
@jerryz123 jerryz123 deleted the revert-periph branch June 15, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants