Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install uart_tsi utility as part of build-toolchain-extra #1670

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jerryz123
Copy link
Contributor

This is useful for bringup.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

cd $RDIR
git submodule update --init generators/testchipip
cd generators/testchipip/uart_tsi
make
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make step will fail on Mac since there are some baudrate constants that are missing on Mac's version of termios.h. Is there a reason we need to use termios baud rate constants? If we just replace them with the actual values it will work on Mac.

There's also some Linux warnings that end up erroring on Mac, so we should probably fix that before merging this in.

If having this work on Mac is important, I can make a PR to fix the uart_tsi code to work on Mac and linux.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize people were building this on Mac. Would this be the only thing that breaks the Mac build? If so, then we should fix this.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't actually built the extra toolchain on Mac, so if Mac isn't necessary to be supported we probably don't need to change uart_tsi. I only got uart_tsi to work on Mac but eventually just used a Linux VM since I only wanted to have the riscv-toolchain installed on Linux.

@jerryz123 jerryz123 merged commit eba1b36 into main Nov 28, 2023
52 checks passed
@T-K-233 T-K-233 deleted the uart_tsi_install branch December 1, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants