Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSimRocketConfig with no TLMonitors #1752

Merged
merged 3 commits into from
Jan 22, 2024
Merged

FastSimRocketConfig with no TLMonitors #1752

merged 3 commits into from
Jan 22, 2024

Conversation

joonho3020
Copy link
Contributor

@joonho3020 joonho3020 commented Jan 22, 2024

Due to the active chiplet development, the complexity of TLMonitors has exploded 😢 .
This causes RTL simulation speed to go down by 2x which is a significant regression.
We want to add a example configuration where we remove the TLMonitors and add some documentation of this phenomenon.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 changed the title NO TLMonitors in the default configuration FastSimRocketConfig with no TLMonitors Jan 22, 2024
Copy link
Contributor

@jerryz123 jerryz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the text in the PR to reflect the new change, then I'll approve


class FastRTLSimRocketConfig extends Config(
new freechips.rocketchip.subsystem.WithoutTLMonitors ++
new chipyard.RocketConfig)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is nowhere in the docs that has a concrete example of overriding the default CONFIG. Maybe this isn't necessary... but perhaps one line can be added:

To simulate this config, you can run:

`make run-binary CONFIG=FastRTLSimRocketConfig BINARY=... LOADMEM=1` 

@joonho3020 joonho3020 merged commit de20656 into main Jan 22, 2024
52 checks passed
@joonho3020 joonho3020 deleted the no-tlmon branch January 22, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants