Pull in IceNet checksum offload changes #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhemao
requested review from
davidbiancolin,
alonamid and
a0u
and removed request for
alonamid and
davidbiancolin
a0u
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
RTL changes look fine.
@zhemao: Have you confirmed that the icenet Linux driver included in marshal still works? I assume that it would, since if I'm not mistaken, the MMIO interface hasn't changed and the checksum offload is optional at runtime.
jerryz123
reviewed
Dec 13, 2019
|
|
||
| class TopWithIceNICModule(outer: TopWithIceNIC) | ||
| extends TopModule(outer) | ||
| with HasPeripheryIceNICModuleImp |
There was a problem hiding this comment.
This should be refactored as CanHavePeripheryIceNICModuleImp, but I guess I can do that in the future.
There was a problem hiding this comment.
The BlockDevice doesn't use CanHave* either currently. We should just do all of them in one go later on.
zhemao
force-pushed
the
icenet-update
branch
from
d3ca0d8
to
1e0c5c5
Compare
|
@a0u Just tested it and the existing icenet-driver still works with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.