-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump verilator to v4.034 #547
Conversation
* Add new flags to verilator makefile
sims/verilator/Makefile
Outdated
VERILATOR_NONCC_OPTS = \ | ||
--timescale 1ns/1ps \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider having the argument part of this pulled out since we give the same value to both verilator and vcs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could just put it in SIM_FLAGS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately one of them wants 2 dashes and the other wants 1 so I was only suggestions lifting the standard verilog 1ns/1ps
.
Its too much work for now but it would be nice to keep things DRY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$(SIM_FLAG_DASHES)timescale 1ns/1ps
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's that chef-albert garnishing gif when you need it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it.
Per reviewer feedback, I made the addition of the flag conditional on Verilator being new enough to support it. This will stop the new Makefile changes from breaking if people don't update their Verilator installs. |
Related issue: verilator/verilator#2300
Type of change: bug fix
Impact: tool change
Release Notes
The default version of Verilator has changed to v4.034. Since this release adds enhanced support for Verilog timescales, a simpler behavior closer to that seen with previous versions is emulated by default with a flat
--timescale
argument.