Importing dsptools.numbers._ now includes implicits by default #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebe
commented
Sep 12, 2017
| @@ -107,6 +107,14 @@ class DspReal(lit: Option[BigInt] = None) extends Bundle { | |||
| oneOperandOperator(Module(new BBFCeil())) | |||
| } | |||
|
|
|||
| def round(): DspReal = (this + DspReal(0.5)).floor() | |||
There was a problem hiding this comment.
@shunshou, DspReal has some things that call the typeclass, especially truncate. That seemed bad. This may change the current behavior, though, because the implementation of truncate here doesn't have pipeline registers.
grebe
commented
Sep 12, 2017
| @@ -71,7 +71,7 @@ trait DspRealIsReal extends Any with IsReal[DspReal] with DspRealOrder with DspR | |||
| def isWhole(a: DspReal): Bool = a === round(a) | |||
| // Round *half up* -- Different from System Verilog definition! (where half is rounded away from zero) | |||
| // according to 5.7.2 (http://www.ece.uah.edu/~gaede/cpe526/2012%20System%20Verilog%20Language%20Reference%20Manual.pdf) | |||
| def round(a: DspReal): DspReal = floor(a + DspReal(0.5)) | |||
| def round(a: DspReal): DspReal = a.round() | |||
| def truncate(a: DspReal): DspReal = { | |||
There was a problem hiding this comment.
Should this be called context_truncate?
grebe
commented
Sep 12, 2017
| @@ -0,0 +1,14 @@ | |||
| package dsptools | |||
|
|
|||
| package object numbers extends AllSyntax with AllImpl with spire.syntax.RingSyntax | |||
There was a problem hiding this comment.
I read somewhere that sometimes people will have a lowercase package (I think) without the implicit and an uppercase version of the package (I think) with the implicits. Is that something we should think about doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposed some interesting little weird things. I'll add some inline comments.
Closes #22