Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline register after LoopMatmul units #60

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Feb 12, 2021

This seems like it should not break anything or affect performance. This cuts up a critical path

@hngenc
Copy link
Member

hngenc commented Feb 12, 2021

@jerryz123 Can you make sure this passes the tiled_matmul_ws*.c tests on VCS? (Not just in CI)

@jerryz123
Copy link
Contributor Author

Sure, I'll check that

@hngenc
Copy link
Member

hngenc commented Feb 12, 2021

@jerryz123 I think it would be a lot easier to revert all your changes and just add a new queue here instead:

unrolled_cmd.ready := false.B

It can just be a default queue (pipe doesn't need to be true.B).

That will almost certainly pass CI without any hiccups. (I'm not sure why CI is failing now; your current changes seem benign enough. But my suggestion will be even more benign and easy to implement).

@jerryz123
Copy link
Contributor Author

This looks good. Do you still want me to check this on manual tests?

Copy link
Member

@hngenc hngenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. This is a minor enough change that I don't think we need to check this manually

@jerryz123 jerryz123 merged commit 2f645ad into dev Feb 13, 2021
@hngenc hngenc deleted the loopmatmul-pipe branch February 13, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants