Midas integration #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tDecoupled to be new HostPort, added new HostDecoupled. Importantly, these don't force hostBits to be Outputs like Chisel Decoupled does
donggyukim
reviewed
Sep 28, 2016
| @@ -1,10 +1,11 @@ | |||
| package strober | |||
|
|
|||
| import midas_widgets._ | |||
| import dram_midas._ | |||
There was a problem hiding this comment.
Why do we need this dependency?
There was a problem hiding this comment.
Which? On dram_midas? Or on widgets?
There was a problem hiding this comment.
No we don't need it, it was just easier for the time being.
Do you think i should just pass some () => MemoryModel through the config? Or can you think of a better way to parameterize this in the short term?
There was a problem hiding this comment.
I just can't compile it without dram_midas. Let's figure out how we can remove this dependency.
There was a problem hiding this comment.
Yeah, sounds good. The purpose of this PR was mainly to solicit feedback. We can talk about how we want to do that tomorrow.
…into midas_integration
donggyukim
force-pushed
the
midas_integration
branch
from
71688bb
to
8d3917b
Compare
|
I confirm this works on FPGA. |
Closed
davidbiancolin
pushed a commit
to davidbiancolin/midas
that referenced
this pull request
Oct 18, 2019
Midas integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened this PR mainly for review.
I've pulled all the source from midas into midas_widgets and kept the history. I can remove the history if you prefer.