Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a toggle for 0 demands #9

Closed
qjhart opened this issue May 6, 2015 · 8 comments
Closed

Add a toggle for 0 demands #9

qjhart opened this issue May 6, 2015 · 8 comments
Assignees

Comments

@qjhart
Copy link
Contributor

qjhart commented May 6, 2015

For applications that have a 0 demand (because of the season), we should be able to have a toggle in the legend that allows for these to be toggled on and off in terms of visibility. Also, can we think of not having them match any of the colors in the shortage or met demand scales?

@brmagnuson
Copy link
Collaborator

This is a great idea! Maybe they could be hollow shapes (not filled in with a color or grey) when they are displayed on the map.

@jrmerz
Copy link
Collaborator

jrmerz commented May 8, 2015

Hollow is good, but hard to show in the legend, they will just be white. If we apply a color, they will really pop and my guess is that we want the opposite of that..... hummm.

@qjhart
Copy link
Contributor Author

qjhart commented May 8, 2015

They could also be an even smaller null sign, ∅

On Fri, May 8, 2015 at 7:06 AM Justin Merz notifications@github.com wrote:

Hollow is good, but hard to show in the legend, they will just be white.
If we apply a color, they will really pop and my guess is that we want the
opposite of that..... hummm.


Reply to this email directly or view it on GitHub
#9 (comment).

@jrmerz
Copy link
Collaborator

jrmerz commented May 8, 2015

That should work... though the legend is rendered as canvas and map is svg. Will verify I can create that icon in both. Should be doable.

@jrmerz
Copy link
Collaborator

jrmerz commented May 8, 2015

Added @ 0f992fd. pushed as well

@brmagnuson
Copy link
Collaborator

This cleans things up a lot! Looks much better. Any chance the null sign could be water-right-type specific? As is the null sign makes it look like all the zero-demand users are riparian because of the circle.

@jrmerz
Copy link
Collaborator

jrmerz commented May 12, 2015

Ok, the empty nodes will now render as their type as well as empty. This pushed me to rewrite the marker/icon rendering into a consolidated function using the canvas tag. What this means, I might have broken some things, let me know if you see any badness.

@qjhart
Copy link
Contributor Author

qjhart commented May 12, 2015

Looks good!

@jrmerz jrmerz closed this as completed May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants