Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather than modifying fields on an existing content type, is it a better idea to simply override the entire module that provides the content type? #5

Closed
dearmond opened this issue May 8, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@dearmond
Copy link
Member

dearmond commented May 8, 2017

The only requirement then would be that the content type machine name is named the same as the base machine name

@dearmond dearmond added this to the Discovery milestone May 8, 2017
@mrkmiller mrkmiller self-assigned this May 15, 2017
@mrkmiller
Copy link
Contributor

I feel like this one is really a judgement call of the subprofile. If I was only adding a field or 2 then I would just override the bits that need changing. This way I would still get all the config for things like path alias, sitemap settings, and upgrades. Also if the base module provides hooks or classes that are being used then these would not want to be duplicated.

However, if it turns into an issue where more fields are custom than original, or if current fields need to work differently like allowing unlimited entries instead of a single one, then it seems like a complete module override would be better.

In general, I would say NO, don't completely override a module.

@mrkmiller mrkmiller assigned dearmond and unassigned mrkmiller May 15, 2017
@dearmond
Copy link
Member Author

Agreed.

I think this question is a spin-off of several of the others. To word it another way: are config overrides in subprofiles so inflexible that subprofiles have to replace the entire module every time?

The answer appears to be "NO". Config overrides in subprofiles seems to be pretty flexible, so it's a judgement call of the subprofile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants