Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Create Discussion Attach Files #621 #622

Merged

Conversation

Thetwam
Copy link
Member

@Thetwam Thetwam commented May 17, 2023

Fix issue where Course.create_discussion_topic doesn't accept attachment files

Fixes #621

@Thetwam Thetwam added the bug label May 17, 2023
@Thetwam Thetwam self-assigned this May 17, 2023
Copy link
Contributor

@bennettscience bennettscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do tests need to be updated to check cases where the file isn't valid?

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #622 (e533efc) into develop (44c61ca) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #622   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         3726      3732    +6     
=========================================
+ Hits          3726      3732    +6     
Impacted Files Coverage Δ
canvasapi/course.py 100.00% <100.00%> (ø)
canvasapi/requester.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Thetwam
Copy link
Member Author

Thetwam commented May 17, 2023

Do tests need to be updated to check cases where the file isn't valid?

Good call, updated.

Copy link
Contributor

@bennettscience bennettscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Thetwam Thetwam added this to the CanvasAPI v3.2.0 milestone May 18, 2023
@Thetwam Thetwam merged commit 4cfa822 into ucfopen:develop May 18, 2023
6 checks passed
@Thetwam Thetwam deleted the issue/621-attach-files-new-discussion-topic branch May 18, 2023 17:25
Thetwam added a commit that referenced this pull request May 25, 2023
* Allow PaginatedList to use metadata for pagination (#614)

* Update `PaginatedList`

Based on #605, `PaginatedList` could not process requests which return
pagination info in the response body. This update checks for `Link` headers
before checking the `meta` property in the response body.

* Update based on review

* Update pag list test with no header no next meta to run properly. Update changelog.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* New Quizzes (#612)

* Begin adding coverage for New Quizzes (WIP)

* Finish New Quizzes endpoints

* Pin urllib3 to <2 for tests due to issue with requests-mock. jamielennox/requests-mock#228

* Course Create Discussion Attach Files #621 (#622)

* Fix issue where Course.create_discussion_topic doesn't accept attachment files

* Add file tests for create_discussion_topic

* Delete method for course and group pages (#624)

* method delete group and course pages, update tests

* format fix

* Add Caitlin to authors. Add contribution to changelog. Formwatting tweaks.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* Remove Jesse as codeowner. Add Matthew Jones and Brian Bennett

* Add support for Python 3.11 (#625)

* markdown styling tweak to be in line with prettier's defaults

* Bump version to 3.2.0

---------

Co-authored-by: Brian <brian.bennett2@gmail.com>
Co-authored-by: Caitlin Fabian <89735646+Caitlin-Fabian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach files when creating a new discussion topic
2 participants