Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete method for course and group pages #624

Merged
merged 3 commits into from
May 24, 2023

Conversation

Caitlin-Fabian
Copy link
Contributor

@Caitlin-Fabian Caitlin-Fabian commented May 24, 2023

Proposed Changes

  • Modified page.py to handle deleting group pages.
  • Added tests for both course pages and group pages.

Fixes #623.

@Caitlin-Fabian Caitlin-Fabian changed the title method delete group and course pages, update tests Delete method for course and group pages May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #624 (078cfb8) into develop (4cfa822) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop      #624   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           73        73           
  Lines         3732      3732           
=========================================
  Hits          3732      3732           
Impacted Files Coverage Δ
canvasapi/page.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Thetwam Thetwam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

I made a few formatting tweaks to docstrings and added you to the authors file. Thanks for your contribution!

@Thetwam Thetwam merged commit c5ffcbf into ucfopen:develop May 24, 2023
Thetwam added a commit that referenced this pull request May 25, 2023
* Allow PaginatedList to use metadata for pagination (#614)

* Update `PaginatedList`

Based on #605, `PaginatedList` could not process requests which return
pagination info in the response body. This update checks for `Link` headers
before checking the `meta` property in the response body.

* Update based on review

* Update pag list test with no header no next meta to run properly. Update changelog.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* New Quizzes (#612)

* Begin adding coverage for New Quizzes (WIP)

* Finish New Quizzes endpoints

* Pin urllib3 to <2 for tests due to issue with requests-mock. jamielennox/requests-mock#228

* Course Create Discussion Attach Files #621 (#622)

* Fix issue where Course.create_discussion_topic doesn't accept attachment files

* Add file tests for create_discussion_topic

* Delete method for course and group pages (#624)

* method delete group and course pages, update tests

* format fix

* Add Caitlin to authors. Add contribution to changelog. Formwatting tweaks.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* Remove Jesse as codeowner. Add Matthew Jones and Brian Bennett

* Add support for Python 3.11 (#625)

* markdown styling tweak to be in line with prettier's defaults

* Bump version to 3.2.0

---------

Co-authored-by: Brian <brian.bennett2@gmail.com>
Co-authored-by: Caitlin Fabian <89735646+Caitlin-Fabian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Group Pages
2 participants