Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach files when creating a new discussion topic #621

Closed
Thetwam opened this issue May 17, 2023 · 0 comments · Fixed by #622
Closed

Attach files when creating a new discussion topic #621

Thetwam opened this issue May 17, 2023 · 0 comments · Fixed by #622
Assignees
@Thetwam
Labels
bug
Milestone
CanvasAPI v3.2.0

Comments

@Thetwam
Copy link
Member

Thetwam commented May 17, 2023

Describe the bug

Unable to upload attachment files in Course.create_discussion_topic

To Reproduce

See discussion #620 (thanks @SebasMeza)

Possible Solutions

This is a symptom of a larger problem with file handling. The library doesn't currently allow for files to be passed as arbitrary keyword arguments. That's a feature we should probably look into at some point (in a new issue), but for the purposes of this issue we can use an optional argument assignment and the file_or_path util function to achieve the same effect, like in Course.import_outcome. Since assignment isn't mandatory, the implementation will be slightly different.
@Thetwam Thetwam added the bug label May 17, 2023
@Thetwam Thetwam added this to the CanvasAPI v3.2.0 milestone May 17, 2023
@Thetwam Thetwam self-assigned this May 17, 2023
@Thetwam Thetwam mentioned this issue May 17, 2023
Merged
Thetwam added a commit that referenced this issue May 18, 2023
@Thetwam
Course Create Discussion Attach Files #621 (#622)
4cfa822 
* Fix issue where Course.create_discussion_topic doesn't accept attachment files

* Add file tests for create_discussion_topic
Thetwam added a commit that referenced this issue May 25, 2023
@Thetwam @bennettscience @Caitlin-Fabian
Release v3.2.0 (#626)
524bfd7 
* Allow PaginatedList to use metadata for pagination (#614)

* Update `PaginatedList`

Based on #605, `PaginatedList` could not process requests which return
pagination info in the response body. This update checks for `Link` headers
before checking the `meta` property in the response body.

* Update based on review

* Update pag list test with no header no next meta to run properly. Update changelog.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* New Quizzes (#612)

* Begin adding coverage for New Quizzes (WIP)

* Finish New Quizzes endpoints

* Pin urllib3 to <2 for tests due to issue with requests-mock. jamielennox/requests-mock#228

* Course Create Discussion Attach Files #621 (#622)

* Fix issue where Course.create_discussion_topic doesn't accept attachment files

* Add file tests for create_discussion_topic

* Delete method for course and group pages (#624)

* method delete group and course pages, update tests

* format fix

* Add Caitlin to authors. Add contribution to changelog. Formwatting tweaks.

---------

Co-authored-by: Matthew Emond <me@ucf.edu>

* Remove Jesse as codeowner. Add Matthew Jones and Brian Bennett

* Add support for Python 3.11 (#625)

* markdown styling tweak to be in line with prettier's defaults

* Bump version to 3.2.0

---------

Co-authored-by: Brian <brian.bennett2@gmail.com>
Co-authored-by: Caitlin Fabian <89735646+Caitlin-Fabian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thetwam Thetwam

Labels
bug
Projects
None yet
Milestone
CanvasAPI v3.2.0
Development

Successfully merging a pull request may close this issue.

Course Create Discussion Attach Files #621 Thetwam/canvasapi
1 participant
@Thetwam