Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-spinners from 0.6.1 to 0.7.1 #155

Merged
merged 2 commits into from
Dec 23, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps react-spinners from 0.6.1 to 0.7.1.

Release notes

Sourced from react-spinners's releases.

Simplify API by removing unit props

The component API has been simplified. The length prop can now accept number or string.

Major Changes

  • all unit props are deprecated, including sizeUnit, heightUnit, widthUnit, and radiusUnit. The size, height, width, and radius props now accepts number and string.
    • If value is number, default to px
    • If value is string with valid css unit, return the input value
    • If value is string with invalid css unit, output warning console log and default to px
  • margin prop now works the same way as other length props. Can accept number and string

Minor Changes

  • css prop default is now "". No functionality change here.
  • fix margin prop functionality on FadeLoader and RotateLoader so it actually expands the spacing between the elements.
  • update the README color prop section to include a list of available color words accepted.
  • clean up README formatting using the prettier plugin
  • add yarn installation instruction to the README.
Changelog

Sourced from react-spinners's changelog.

0.7.1

  • run npm audit fix to fix vulnerability in serialslize-javascript package
  • update README to showcase number and string input for size prop.

0.7.0

  • BREAKING CHANGE: all unit props have been removed to simplify the component API. See change log for 0.7.0-alpha.1 for more details.

0.7.0-beta.1

  • Update readme to include yarn installation

0.7.0-alpha.5

  • clean up readme. break up prop section with individual prop headers

0.7.0-alpha.4

  • update default value for css prop on README to be "" instead of {}
  • add list of available color words that the color prop accepts.
  • run prettier to format readme

0.7.0-alpha.3

0.7.0-alpha.2

  • bugfix: Fix [issue #139](davidhu2000/react-spinners#139). The margin prop on RotateLoader does what we expect it to do, expand the spacing between the dots.
  • updated webpack config to split up npm files to avoid brower having to reload them on each change.

0.7.0-alpha.1

  • BREAKING CHANGE: all unit props are deprecated, including sizeUnit, heightUnit, widthUnit, and radiusUnit. The size, height, width, and radius props now accepts number and string.
    • If value is number, default to px
    • If value is string with valid css unit, return the input value
    • If value is string with invalid css unit, output warning console log and default to px
  • margin prop now work the same way as other length props. Can accept number and string
  • css prop default is now "". No functionality change here
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 23, 2019
@mattxwang
Copy link
Collaborator

Ah, this is failing because it doesn't match the snapshot. Let me fix that.

tbh we could have a better loading page
@mattxwang
Copy link
Collaborator

Other than that, react-spinners's change in not accepting unit props doesn't affect us. Should be good to merge.

Copy link
Collaborator

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly passes CI, updated test; LGTM!

@mattxwang mattxwang merged commit b1c980c into master Dec 23, 2019
@mattxwang mattxwang deleted the dependabot/npm_and_yarn/react-spinners-0.7.1 branch December 23, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant