Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editing name intuitive. #174

Merged
merged 3 commits into from
Jan 18, 2020
Merged

Make editing name intuitive. #174

merged 3 commits into from
Jan 18, 2020

Conversation

kilometerskang
Copy link
Contributor

No description provided.

mattxwang
mattxwang approved these changes Jan 18, 2020
View reviewed changes
Copy link
Collaborator

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job Miles! LGTM.

@mattxwang mattxwang merged commit 5447d9c into master Jan 18, 2020
@mattxwang mattxwang deleted the make-editing-name-intuitive branch January 18, 2020 19:39
@mattxwang mattxwang mentioned this pull request Jan 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kilometerskang @mattxwang