Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sketch thumbnail #181

Merged
merged 5 commits into from
Jan 24, 2020
Merged

Added sketch thumbnail #181

merged 5 commits into from
Jan 24, 2020

Conversation

vohndernet
Copy link
Contributor

Sketch thumbnail of program can now be viewed in editor mode.

vohndernet and others added 3 commits January 22, 2020 11:46
@vohndernet
Merge pull request #1 from uclaacm/master
857639b 
Syncing fork
@vohndernet
Added Sketch Thumbnail
939b389 
Sketch Thumbnail is now displayed in editor mode.
@vohndernet
Added Sketch Thumbnail
27e58fc 
Sketch thumbnail can now be viewed in code editor
mattxwang
mattxwang reviewed Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@mattxwang mattxwang left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think it looks good, this is solid work Nhi! Tentatively not approving on a minor CSS tidbit and a bit of thinking on the design of this. Interested to get some other people's opinions on this (@krashanoff , @jamieliu386 , @fan-matt - any thoughts)?

src/styles/Editor.scss Outdated Show resolved Hide resolved
@krashanoff
Copy link
Contributor

Heya Nhi! I really like the idea and things look solid, though there is some strange CSS stuff going on. One small visual bug on Chrome and Firefox I found:

  • Open a program
  • Open and close the sidebar
  • Editor gains overflow
    Screenshot_2020-01-22 Teach LA Editor

@vohndernet
Added sketch thumbnail uclaacm#2
03bf31e 
fixed small css bug when opening panel
@mattxwang
Copy link
Collaborator

Heya Nhi! I really like the idea and things look solid, though there is some strange CSS stuff going on. One small visual bug on Chrome and Firefox I found:
...

Tested this locally w/ Nhi's fix and it seems like it works in Chrome & Firefox. Good catch Leo, I'll defer merging until you confirm that it's good on your end too!

krashanoff
krashanoff approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@krashanoff krashanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked it out, nice work Nhi!

@mattxwang mattxwang merged commit c27ccf1 into uclaacm:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattxwang mattxwang mattxwang left review comments

@krashanoff krashanoff krashanoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vohndernet @krashanoff @mattxwang