Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(very) minor code cleanup! #203

Merged
merged 2 commits into from
Feb 21, 2020
Merged

(very) minor code cleanup! #203

merged 2 commits into from
Feb 21, 2020

Conversation

mattxwang
Copy link
Collaborator

@mattxwang mattxwang commented Feb 14, 2020 •
edited

More (very minor) code cleanup!

  • removes useless constructor, direct function in Login
  • removes unused lifecycle function and commented out code in LoginForm
  • removes unused Dropdown, direct function in Main (this dupes with another merged PR)
  • removes unused reRenderOutput in Output
  • removes unused code param in Output/Processing
  • removes unused constant import in Sketches/index
  • removes unused props in Footer
  • removes unused lifecycle, prevState in ProfilePanel
  • standardizes some colors in Editor.scss, Radio,scss, Panel.scss
  • moves $switch-transition-time to variables.scss

@mattxwang
lots and lots of code cleanup!
b4a302e 
(will include more detailed description in PR)
@mattxwang mattxwang added the refactor Refactoring & cleanup label Feb 14, 2020
@mattxwang mattxwang changed the title [DRAFT] Minor Code Cleanup Minor Code Cleanup Feb 21, 2020
@mattxwang mattxwang changed the title Minor Code Cleanup (very) minor code cleanup! Feb 21, 2020
krashanoff
krashanoff reviewed Feb 21, 2020
View reviewed changes
Copy link
Contributor

@krashanoff krashanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just glanced over the changes and looks good to me. Will do a few quick tests after breakfast and get back to you. Thanks Matt!

krashanoff
krashanoff approved these changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@krashanoff krashanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krashanoff krashanoff merged commit 4e46d4b into master Feb 21, 2020
@krashanoff krashanoff deleted the code-cleanup branch February 21, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krashanoff krashanoff krashanoff approved these changes

Assignees
No one assigned
Labels
refactor Refactoring & cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattxwang @krashanoff