Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Defunct Code #225

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Removing Defunct Code #225

merged 1 commit into from
Mar 12, 2020

Conversation

mattxwang
Copy link
Collaborator

We won't be supporting C++/Java any time soon, and we no longer use the Facebook Auth provider. Removes code references to all of these things.

we won't support C++, Java, or Facebook anytime soon
@mattxwang mattxwang added the refactor Refactoring & cleanup label Mar 9, 2020
Copy link
Contributor

@krashanoff krashanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had always wondered if anything would come to fruition of the CSS/Java endeavors. Regarding JavaScript, we could totally square that away next quarter. In any case LGTM.

@vohndernet vohndernet merged commit b944675 into master Mar 12, 2020
@vohndernet vohndernet deleted the removing-defunct-code branch March 12, 2020 01:06
@vohndernet vohndernet restored the removing-defunct-code branch March 12, 2020 01:08
@mattxwang mattxwang deleted the removing-defunct-code branch March 12, 2020 01:09
Copy link
Contributor

@vohndernet vohndernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I give the all clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring & cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants