Adds Internship Page! #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: flip animation
mattxwang
requested changes
Sep 27, 2021
There was a problem hiding this comment.
I know we're tight on time, so a lighter review than normal.
First, do the cards work? On Chrome/macOS, I get this:
Kapture.2021-09-26.at.17.45.43.mp4
Not sure what's happening here, but that means that none of the cards work.
Broadly, the FAQ component is also still not tabbable.
Re: content changes, you can commit them as a batch at once.
| <p className={styles['application-item-info']}>{item.info}</p> | ||
| </div> | ||
| ))} | ||
| -- more dates will be added throughout the quarter -- |
There was a problem hiding this comment.
We should remove this, right?
There was a problem hiding this comment.
I think we can leave this in, especially considering the timeline is blurred - and confirm with ava in the board meeting when finalizing the timeline
styles/components/Internship/CommitteeInternshipInfo.module.scss
Outdated
Show resolved
Hide resolved
use static copy
mattxwang
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #112
Preliminary Design here!
Aims to explain how ACM's internship program works to prospective interns, giving details about each committee's internship program, the expectations, and the next steps.
Adds
internship.jsinpagesas well as indata,internship.scssand a number of component js and scss files (NextSteps,CommitteeInternshipInfo,InternshipTimeline).Also adds card assets for all the committees and board under
public/images/cardsfrom the Figma.Pending adding data, testimonials and FAQ along with feedback from previous and prospective interns and Ava, the internship director!