Fix broken URLs in views #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortongn
requested changes
Apr 4, 2019
There was a problem hiding this comment.
@bsp3ars I made a couple suggestions to your changes. Also the following parts of the issue are unresolved. Let me know if we need to discuss them because replacements don't exit.
- app/views/layouts/scholar/_links.html.erb:http://libraries.uc.edu/digital-scholarship/data-services
- app/views/hyrax/static/agreement.html.erb:http://www.uc.edu/content/dam/uc/provost/docs/academicpersonnel/a-z/AAUP-UC
- Both app/views/welcome_mailer/welcome_email_student.text.erb and app/views/welcome_mailer/welcome_email_student.html.erb have lots of hard-coded links to Scholar pages instead of using URL helpers.
bsp3ars
force-pushed
the
bug/#699-fix-broken-urls
branch
2 times, most recently
from
97b3894
to
c372227
Compare
|
@bsp3ars There's till unresolved stuff here. See #718 (comment) and #718 (review) |
bsp3ars
force-pushed
the
bug/#699-fix-broken-urls
branch
from
c372227
to
6d3f602
Compare
|
@hortongn this is ready for a review |
hortongn
requested changes
May 17, 2019
| @@ -12,7 +13,7 @@ | |||
| <li> | |||
| Log in to <%=t('hyrax.product_name') %> using the <a href="#" style="color:white;background-color:black;padding:3px;"> | |||
| <span class="glyphicon glyphicon-log-in" aria-hidden="true"></span > Login | |||
| </a> link (upper right corner of <a href="http://curly.libraries.uc.edu:3002/">curly.libraries.uc.edu</a>). | |||
| </a> link (upper right corner of <%= link_to root_path %>). | |||
There was a problem hiding this comment.
This should actually be Rails.application.config.application_root_url instead of root_path. We want the web page to display "http://some.url" but root_path just displays "/"
bsp3ars
force-pushed
the
bug/#699-fix-broken-urls
branch
from
6d3f602
to
ec75989
Compare
|
@hortongn This should be good to go |
hortongn
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699
This should fix all of the listed URLs listed in #699.