Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PART1ONLY option in release.sh doesn't work properly #332

Closed
gcode-importer opened this issue Apr 3, 2014 · 6 comments
Closed

PART1ONLY option in release.sh doesn't work properly #332

gcode-importer opened this issue Apr 3, 2014 · 6 comments

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 332

The goal of PART1ONLY option in the release script (dev-utils/scripts/release.{sh,bat})
is to generate a subset of the OpenJPEG binaries AND sources (with only the openjp2
library, and the opj_compress, opj_decompress, and opj_dump executables).

Currently it only creates a subset for the binaries but include all the sources in
the tar.gz archive.

Reported by detonin on 2014-04-03 21:00:57

@gcode-importer
Copy link
Author

Just for reference. It will be very hard to extract only Part-1 from the OpenJPEG source
code, since src/lib/openjp2 contains pointers and reference to JPIP, MJ2 and JPWL implementation.

It is difficult to automate. The conclusion was that this is a one -time job, which
can be done by hand, when commitee review OpenJPEG code.

Reported by malaterre on 2014-04-28 07:49:30

  • Labels added: Priority-Low
  • Labels removed: Priority-Medium

@gcode-importer
Copy link
Author

Reported by malaterre on 2014-04-28 07:49:43

  • Labels added: Conformance

@gcode-importer
Copy link
Author

@mathieu,

if code in src/lib/openjp2 contains proper defines (I think it does), then a utility
like coan (http://coan2.sourceforge.net) can be used to preprocess the source ode automatically.

Reported by mayeut on 2014-11-22 12:10:22

@gcode-importer
Copy link
Author

@antonin do you think you'll need that in the future ?
@matthieu I have not checked but I think we had to move JPIP-only function within libopenjp2,
I do not believe they were #igdef guarded...

Reported by malaterre on 2014-11-24 08:01:48

@gcode-importer
Copy link
Author

@mathieu No we'll not need this in the future so it can actually be removed from CMake
options.

Reported by detonin on 2014-11-24 12:22:59

@gcode-importer
Copy link
Author

I did not remove the option as it might be useful to build only PART1 related components
but I close the issue because there is no need anymore to also package a subset of
the source files.

Reported by detonin on 2015-01-15 17:11:11

  • Status changed: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants