Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images from various security issues to test suite #415

Closed
gcode-importer opened this issue Oct 17, 2014 · 16 comments
Closed

Add images from various security issues to test suite #415

gcode-importer opened this issue Oct 17, 2014 · 16 comments

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 415

The issue is restricted to Coreteam as it contains data from restricted issues.

Add images from :
issue 362
issue 363
issue 390
issue 391
issue 400
issue 413

Please add attached images to http://openjpeg.googlecode.com/svn/data/input/nonregression/

Patch provided for data & trunk for test updates

Reported by mayeut on 2014-10-17 18:24:09


- _Attachment: [issue362-2863.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue362-2863.jp2)_ - _Attachment: [issue362-2866.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue362-2866.jp2)_ - _Attachment: [issue362-2894.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue362-2894.jp2)_ - _Attachment: [issue363-4723.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue363-4723.jp2)_ - _Attachment: [issue363-4740.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue363-4740.jp2)_ - _Attachment: [issue363-4792.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue363-4792.jp2)_ - _Attachment: [issue390.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue390.jp2)_ - _Attachment: [issue391.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue391.jp2)_ - _Attachment: [issue400.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue400.jp2)_ - _Attachment: [issue413.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-0/issue413.jp2)_
@gcode-importer
Copy link
Author

Add missing patches

Reported by mayeut on 2014-10-17 18:38:56


- _Attachment: [issue415-data.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-1/issue415-data.patch)_ - _Attachment: [issue415-trunk.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-1/issue415-trunk.patch)_

@gcode-importer
Copy link
Author

Reported by mayeut on 2014-10-17 18:39:22

  • Labels added: Type-Enhancement
  • Labels removed: Type-Defect

@gcode-importer
Copy link
Author

Reported by detonin on 2014-10-21 13:05:31

  • Labels added: Priority-High
  • Labels removed: Priority-Medium

@gcode-importer
Copy link
Author

This issue was updated by revision r2912.

Thanks Matthieu for preparing this. Issue not closed as in the mean time
there are other images to include

Reported by detonin on 2014-10-22 22:37:04

  • Status changed: Started

@gcode-importer
Copy link
Author

This issue was updated by revision r2913.

Reported by detonin on 2014-10-22 22:38:58

@gcode-importer
Copy link
Author

New round :

Add images from :
issue 364
issue 393
issue 395
issue 397
issue 399
issue 408
issue 418

Please add attached images to http://openjpeg.googlecode.com/svn/data/input/nonregression/

Patch provided for data & trunk for test updates

I did not update md5 for issue 399 as I'd rather let someone (Antonin, Mathieu ?) with
the same compiler/platform as other md5 computed do this (see issue 292 which might
apply at different levels & not only windows x86). => that's one more test failing
than before patch (37=>38 on my setup).

I did not add image from issue 389 (which should be decoded, see issue 406) but image
from issue 395 tests the patch from that issue.
I did not add image from issue 398 which is the same as issue 400
I did not add image from issue 417 which is the same as issue 364
I did not add image from issue 411 as it requires another (may be not wanted) patch
to test the code path for which a fix has been committed. (We can easily see that code
path is never taken with coverage tests I added on the trunk so I'll probably check
in images to test this one day)

Reported by mayeut on 2014-10-23 19:20:29


- _Attachment: [issue364-38.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue364-38.jp2)_ - _Attachment: [issue364-903.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue364-903.jp2)_ - _Attachment: [issue393.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue393.jp2)_ - _Attachment: [issue395.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue395.jp2)_ - _Attachment: [issue397.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue397.jp2)_ - _Attachment: [issue399.j2k](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue399.j2k)_ - _Attachment: [issue408.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue408.jp2)_ - _Attachment: [issue418.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-6/issue418.jp2)_

@gcode-importer
Copy link
Author

Reported by mayeut on 2014-10-24 22:03:00

@gcode-importer
Copy link
Author

Add images from :
issue 412
issue 414
issue 420

I did not update md5 for  issue 412 & issue 414  as I'd rather let someone (Antonin,
Mathieu ?) with the same compiler/platform as other md5 computed do this (see issue
292 which might apply at different levels & not only windows x86). => that's two more
test failing than before patch (38=>40 on my setup).

Please add attached images to http://openjpeg.googlecode.com/svn/data/input/nonregression/

Patch provided for data & trunk for test updates (these have been updated. Patch from
previous comment deleted)

Reported by mayeut on 2014-10-31 19:29:15


- _Attachment: [issue415-part2-data.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-8/issue415-part2-data.patch)_ - _Attachment: [issue412.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-8/issue412.jp2)_ - _Attachment: [issue414.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-8/issue414.jp2)_ - _Attachment: [issue420.jp2](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-8/issue420.jp2)_

@gcode-importer
Copy link
Author

Added test for issue 428
Added md5 sums (better working for one person than missing for everybody). Those can
be changed later if needed.

With patch from issue 428, that's 37 tests failing on my setup (40 - 3 md5 added).
Image from issue 412 reused for issue 428 so no image to add there.

Reported by mayeut on 2014-11-15 12:38:14


- _Attachment: [issue415-part2-trunk.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-415/comment-9/issue415-part2-trunk.patch)_

@gcode-importer
Copy link
Author

This issue was updated by revision r2926.

Reported by mayeut on 2014-11-17 21:58:29

@gcode-importer
Copy link
Author

This issue was updated by revision r2927.

Issue not closed as in the mean time there are other images to include

Reported by mayeut on 2014-11-17 22:02:53

@gcode-importer
Copy link
Author

This issue was updated by revision r2952.

Reported by mayeut on 2014-12-09 19:43:56

@gcode-importer
Copy link
Author

This issue was updated by revision r2953.

Reported by mayeut on 2014-12-09 19:45:17

@gcode-importer
Copy link
Author

This issue was updated by revision r2969.

Reported by mayeut on 2014-12-20 15:08:56

@gcode-importer
Copy link
Author

This issue was updated by revision r2970.

Reported by mayeut on 2014-12-20 15:09:07

@mayeut
Copy link
Collaborator

mayeut commented Jul 12, 2015

Other images shall be uploaded using original issue number.
Closing.

@mayeut mayeut closed this as completed Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants