Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations are mixed with modifier #78

Closed
nimakarimipour opened this issue Sep 20, 2022 · 1 comment · Fixed by #79
Closed

Annotations are mixed with modifier #78

nimakarimipour opened this issue Sep 20, 2022 · 1 comment · Fixed by #79
Assignees
Labels
bug Something isn't working

Comments

@nimakarimipour
Copy link
Member

nimakarimipour commented Sep 20, 2022

Describe the bug
Added annotations are getting mixed with the modifier.

-  @JsonProperty public List<String> bar;
+  @JsonPropertypublic @Nullable  List<String> bar;

Or

-  @JsonProperty
-  @JsonInclude(JsonInclude.Include.NON_NULL)
-  public String foo;
+  @JsonProperty @JsonInclude(JsonInclude.Include.NON_NULL) @Nullable
+@Nullablepublic   String foo;

To Reproduce

  • The root cause is not detected yet.

Expected behavior

-  @JsonProperty
-  @JsonInclude(JsonInclude.Include.NON_NULL)
-  public String foo;
+  @JsonProperty @JsonInclude(JsonInclude.Include.NON_NULL) @Nullable
+  public   String foo;

and

-  @JsonProperty public List<String> bar;
+  @JsonProperty public @Nullable  List<String> bar;

Stack trace
Not-Applicable.

OS (please complete the following information):

  • Annotator Version [e.g. v1.3.3-SNAPSHOT]

Additional context
This is a subproblem of #77

@nimakarimipour nimakarimipour added the bug Something isn't working label Sep 20, 2022
@nimakarimipour nimakarimipour self-assigned this Sep 20, 2022
nimakarimipour added a commit that referenced this issue Sep 20, 2022
This PR resolves #78 by downgrading javaparser to version `3.24.0`.
@nimakarimipour
Copy link
Member Author

#90 is landed and resolves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant