Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb labels no longer working with loadChildren #178

Closed
MelanieW97 opened this issue Oct 26, 2023 · 5 comments
Closed

Breadcrumb labels no longer working with loadChildren #178

MelanieW97 opened this issue Oct 26, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MelanieW97
Copy link

MelanieW97 commented Oct 26, 2023

🐞 Bug report

Description

I upgraded from version 10.0.0 to 10.0.1. Ever since, the defined breadcrumbs are no longer working for me.
Before:
Home

After:
Home / / [object object] >>

The routes did not change.
xng-breadcrumb seems to handle them different than before.

The documentation says you can set the breadcrumb on the child or the parent for loadChildren. That does not seem to work anymore - at least for my project.

🔬 Minimal Reproduction

Define routes with loadChildren, e.g.:

image

Then in the HomeModule:

image

It was working in version 10.0.0. Maybe it's a bug or maybe you can tell me what I need to change right there in order to get it to work again.

💻Your Environment

Angular Version:


Angular CLI: 16.2.8
@MelanieW97 MelanieW97 added the bug Something isn't working label Oct 26, 2023
@github-actions
Copy link

Hello 👋 @MelanieW97
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@MelanieW97
Copy link
Author

Hey,

I have just noticed it is no longer working on the demo website, either. No idea which version of the package you use right there, though.

Take a look.
image
https://xng-breadcrumb.vercel.app/mentor/add?type=add

Greetings! Have a wonderful day!

@udayvunnam
Copy link
Owner

Thanks @MelanieW97, please use 10.0.0 for now. The last merged PR #177 may have caused this. I will check this

@cskiwi cskiwi mentioned this issue Nov 20, 2023
3 tasks
@liqMats
Copy link

liqMats commented Nov 28, 2023

The downgrade to 10.0.0 is a workaround for me. @udayvunnam can you please take a look at the pull request #180, which hopefully fixes this permanently? Thank you!

@udayvunnam
Copy link
Owner

@MelanieW97 @liqMats the fix is published on `xng-breadcrumb@10.0.21 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants