Fixes #456 Escaping App Name (#459)

* escape app_name param * escape app_name param * Issue 456 unescaped app name Co-authored-by: Noi Narisak <noi.narisak+github@gmail.com>
udplabs · Oct 29, 2021 · 037d6b5 · 037d6b5
1 parent 3769090
commit 037d6b5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/GlobalBehaviorandComponents/login.py b/GlobalBehaviorandComponents/login.py
@@ -9,6 +9,8 @@
 from utils.okta import OktaAuth, OktaAdmin, TokenUtil
 from utils.udp import apply_remote_config, clear_session_setting, SESSION_INSTANCE_SETTINGS_KEY, get_app_vertical
 from utils.udp import clear_session_decorator
+from json import dumps
+
 
 from GlobalBehaviorandComponents.validation import get_userinfo, check_okta_api_token, check_zartan_config
 
@@ -98,7 +100,8 @@ def gbac_login():
             linkedin=linkedin,
             microsoft=microsoft,
             idp=idp,
-            idptype=idptype)
+            idptype=idptype,
+            dumps=dumps)
 
 
 @gbac_bp.route("/signup")

diff --git a/GlobalBehaviorandComponents/templates/components/template-login-widget-pwless.html b/GlobalBehaviorandComponents/templates/components/template-login-widget-pwless.html
@@ -61,7 +61,7 @@
                       redirectUri: "{{config.redirect_uri}}",
                       i18n: {
                         en: {
-                          'primaryauth.title': 'Sign in to {{config.settings.app_name|safe}}'
+                          'primaryauth.title': "Sign in to "+{{dumps(config.settings.app_name)|safe}}
                         }
                       },
                       features: {

diff --git a/GlobalBehaviorandComponents/templates/components/template-login-widget.html b/GlobalBehaviorandComponents/templates/components/template-login-widget.html
@@ -113,7 +113,7 @@
                       },
                       i18n: {
                         en: {
-                          'primaryauth.title': 'Sign in to {{config.settings.app_name|safe}}'
+                          'primaryauth.title': "Sign in to "+{{dumps(config.settings.app_name)|safe}}
                         }
                       },
                       features: {
@@ -198,4 +198,4 @@
         </div>
 
     </section>
-    <!-- page-wrapper end -->
+    <!-- page-wrapper end -->