Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] When you use apostrophe in Application Name breaks SIW from displaying #456

Closed
noinarisak opened this issue Aug 19, 2021 · 0 comments · Fixed by #459
Closed

[BUG] When you use apostrophe in Application Name breaks SIW from displaying #456

noinarisak opened this issue Aug 19, 2021 · 0 comments · Fixed by #459
Labels
type: bug Something isn't working

Comments

@noinarisak
Copy link
Contributor

Describe the bug
When I configure Ecommerce vertical, probably other verticals too, it breaks the rending of Okta Sign-In Widget.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Ecommerce edit screen on UDP dashboard.
  2. Add apostrophe to the Application Name field and save.
  3. Launch the demo application.
  4. Click on the Login button
  5. Sign-In Widget is not rendered.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Screen Shot 2021-08-19 at 10 44 59 AM
Screen Shot 2021-08-19 at 10 53 09 AM

Desktop (please complete the following information):

  • OS: macOS
  • Browser: chrome
  • Version: 92

Additional context
n/a
@noinarisak noinarisak added the type: bug Something isn't working label Aug 19, 2021
@RyAndrew RyAndrew mentioned this issue Oct 15, 2021
Merged
noinarisak added a commit that referenced this issue Oct 29, 2021
@RyAndrew @noinarisak
Fixes #456 Escaping App Name (#459)
037d6b5 
* escape app_name param

* escape app_name param

* Issue 456 unescaped app name

Co-authored-by: Noi Narisak <noi.narisak+github@gmail.com>
@noinarisak noinarisak mentioned this issue Jan 27, 2022
Merged
lucassrg pushed a commit to lucassrg/zartan that referenced this issue Feb 2, 2022
@RyAndrew @noinarisak
Fixes udplabs#456 Escaping App Name (udplabs#459)
f51a0a6 
* escape app_name param

* escape app_name param

* Issue 456 unescaped app name

Co-authored-by: Noi Narisak <noi.narisak+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #456 Escaping App Name RyAndrew/zartan
1 participant
@noinarisak