Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #456 Escaping App Name #459

Merged
merged 4 commits into from
Oct 29, 2021
Merged

Fixes #456 Escaping App Name #459

merged 4 commits into from
Oct 29, 2021

Conversation

RyAndrew
Copy link
Contributor

Fixes #456 Escaping App Name

@noinarisak noinarisak added the type: bug Something isn't working label Oct 29, 2021
@noinarisak noinarisak self-requested a review October 29, 2021 16:31
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Please retry analysis of this Pull-Request directly on SonarCloud.

Copy link
Contributor

@noinarisak noinarisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@noinarisak noinarisak merged commit 037d6b5 into udplabs:master Oct 29, 2021
lucassrg pushed a commit to lucassrg/zartan that referenced this pull request Feb 2, 2022
* escape app_name param

* escape app_name param

* Issue 456 unescaped app name

Co-authored-by: Noi Narisak <noi.narisak+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When you use apostrophe in Application Name breaks SIW from displaying
2 participants